Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toolbox: add default service account to toolbox #2511

Closed
wants to merge 1 commit into from
Closed

toolbox: add default service account to toolbox #2511

wants to merge 1 commit into from

Conversation

parth-gr
Copy link
Member

currently scc are updated to remove the k8s default service account, so toolbox should start with rook-ceph-default service account

@parth-gr
Copy link
Member Author

/review @travisn @iamniting

@parth-gr
toolbox: add default service account to toolbox
7d8c88f 
currently scc are updated to remove the k8s default service account,
so toolbox should start with rook-ceph-default service account

Signed-off-by: parth-gr <[email protected]>
@travisn
Copy link
Contributor

travisn commented Mar 15, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
@parth-gr parth-gr mentioned this pull request Mar 15, 2024
Merged
6 tasks
jarrpa
jarrpa approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa, parth-gr, travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2024
@jarrpa
Copy link
Member

jarrpa commented Mar 16, 2024

Looks like the e2e-test is failing at deploying the toolbox pod. Should definitely look into it.

@iamniting
Copy link
Member

/test ocs-operator-bundle-e2e-aws

@parth-gr
Copy link
Member Author

parth-gr commented Mar 18, 2024 •
edited
Loading

@iamniting how to understand what is failing in the CI(I see : Run multi-stage test ocs-operator-bundle-e2e-aws - ocs-operator-bundle-e2e-aws-e2e-test container test expand_more 29m2s
: Run multi-stage test test phase expand_m), can we look at the CI cluster somehow?

And I believe we would have the latest csv change to create the default service account in the ci red-hat-storage/rook#589

@malayparida2000
Copy link
Contributor

/test ocs-operator-bundle-e2e-aws

@malayparida2000
Copy link
Contributor

malayparida2000 commented Mar 18, 2024 •
edited
Loading

Our CI have been failing randomly with a noobaa issue, the Noobaa CR stays stuck in the configuring phase. Here are the logs from the noobaa-operator.

2024-03-18T05:26:38.659054113Z time="2024-03-18T05:26:38Z" level=info msg="identified aws region us-west-2" sys=openshift-storage/noobaa
2024-03-18T05:26:38.659142872Z time="2024-03-18T05:26:38Z" level=info msg="creating bucket nb.1710738289550.makestoragegreatagain.com" sys=openshift-storage/noobaa
2024-03-18T05:26:39.017993075Z time="2024-03-18T05:26:39Z" level=error msg="got error when trying to create bucket nb.1710738289550.makestoragegreatagain.com. error: RequestError: send request failed\ncaused by: Put \"https://s3.us-west-2.amazonaws.com/nb.1710738289550.makestoragegreatagain.com\": tls: failed to verify certificate: x509: certificate signed by unknown authority" sys=openshift-storage/noobaa
2024-03-18T05:26:39.017993075Z time="2024-03-18T05:26:39Z" level=info msg="SetPhase: temporary error during phase \"Configuring\"" sys=openshift-storage/noobaa
2024-03-18T05:26:39.018054812Z time="2024-03-18T05:26:39Z" level=warning msg="⏳ Temporary Error: RequestError: send request failed\ncaused by: Put \"https://s3.us-west-2.amazonaws.com/nb.1710738289550.makestoragegreatagain.com\": tls: failed to verify certificate: x509: certificate signed by unknown authority" sys=openshift-storage/noobaa
2024-03-18T05:26:39.029071517Z time="2024-03-18T05:26:39Z" level=info msg="UpdateStatus: Done generation 1" sys=openshift-storage/noobaa
2024-03-18T05:26:39.029125989Z time="2024-03-18T05:26:39Z" level=info msg="Update event detected for noobaa (openshift-storage), queuing Reconcile"

@parth-gr parth-gr mentioned this pull request Mar 18, 2024
Merged
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 18, 2024

@parth-gr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocs-operator-bundle-e2e-aws 7d8c88f link true /test ocs-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@parth-gr
Copy link
Member Author

@jarrpa I cant find the CI failing because of toolbox, it looks like a different issue,
Plus we need the update of the rook image in the OCS CI which is coming from #2507
So they both are dependent to eachother

@jarrpa
Copy link
Member

jarrpa commented Mar 18, 2024

If it's a strict dependency then it should be marked as such in the PR description, and we gotta wait. Something like this that messes with RBAC should not be merged without the e2e-tests passing, it could destabilize the downstream builds.

@parth-gr
Copy link
Member Author

If it's a strict dependency then it should be marked as such in the PR description, and we gotta wait. Something like this that messes with RBAC should not be merged without the e2e-tests passing, it could destabilize the downstream builds.

Sure I believe we can merge the two PR.

@parth-gr
Copy link
Member Author

parth-gr commented Mar 19, 2024 •
edited
Loading

Closing as the api change PR #2507 has the above change

@parth-gr parth-gr closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrpa jarrpa jarrpa approved these changes

Assignees

@travisn travisn

@jarrpa jarrpa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@parth-gr @travisn @jarrpa @iamniting @malayparida2000